Fix color selection off-by-one error and dangling Y-beam #18798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
approved these changes
Apr 15, 2025
DHowett
approved these changes
Apr 15, 2025
DHowett
pushed a commit
that referenced
this pull request
Apr 16, 2025
(cherry picked from commit 0b4f966) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgZYtao Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes a bug where the color selection actions would color one more character than they needed to.
Also fixes a bug where if mark mode was used to create the selection, a dangling y-beam would be left over after executing the action.
References and Relevant Issues
Regressed in #18106
Detailed Description of the Pull Request / Additional comments
TextBuffer::SpanLengthwas only used once (inTerminal::ColorSelection). All it really did was callViewport::CompareInBounds. So I deduplicated it._updateSelectionUIinControlCore::ColorSelection. This heuristic is used throughout the file for other selection-related functions.Validation Steps Performed
✅ color selection action highlights reference(s) to selected text
✅ color selection action highlights reference(s) to selected text when text is at right boundary
✅ dangling y-beam disappears after executing color selection actions
Closes #18739