Fix missing icon and truncated text on NullableColorPicker #18476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
reviewed
Jan 30, 2025
| <comment>Label for a button directing the user to use the background color defined in the terminal's current color scheme.</comment> | ||
| </data> | ||
| <data name="Profile_SelectionBackground_NullableColorPicker.NullColorButtonLabel" xml:space="preserve"> | ||
| <value>Use selection background color from color scheme</value> | ||
| <value>Selection background color from color scheme</value> |
There was a problem hiding this comment.
i wonder... should we shorten all of these to "Use scheme color"? then we only have one?
There was a problem hiding this comment.
For the record, it would look like this:
I think that'd be fine, but for anybody that comes along, please share your thoughts 😊
DHowett
approved these changes
Jan 30, 2025
DHowett
reviewed
Feb 3, 2025
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
DHowett
approved these changes
Feb 4, 2025
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani,
DHowett and
lhecker
lhecker
approved these changes
Feb 4, 2025
microsoft-github-policy-service
bot
removed
the
Needs-Second
DHowett
pushed a commit
that referenced
this pull request
Feb 4, 2025
Fixes an issue on Windows 10 where icon on selected color chips would be missing in the NullableColorPicker. Fixes (or at least significantly improves the experience) text being truncated for the special colors in the NullableColorPicker. This was done by removing the word "Use" from the labels and adding a visual state trigger to change the layout of the chips and buttons when the window becomes narrow. Related to #18318 (cherry picked from commit 7423dd3) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgXARtg Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue on Windows 10 where icon on selected color chips would be missing in the NullableColorPicker.
Fixes (or at least significantly improves the experience) text being truncated for the special colors in the NullableColorPicker. This was done by removing the word "Use" from the labels and adding a visual state trigger to change the layout of the chips and buttons when the window becomes narrow.
Related to #18318