-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nullable colors and improve Profile.Icon in settings UI #17870
Open
carlos-zamora
wants to merge
18
commits into
main
Choose a base branch
from
dev/cazamor/SUI/nullable-color-picker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4fe421c - Browse repository at this point
Copy the full SHA 4fe421cView commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15922b7 - Browse repository at this point
Copy the full SHA 15922b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 153d97e - Browse repository at this point
Copy the full SHA 153d97eView commit details
Commits on Aug 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e3e0b93 - Browse repository at this point
Copy the full SHA e3e0b93View commit details
Commits on Sep 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c3d2e98 - Browse repository at this point
Copy the full SHA c3d2e98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 629ed07 - Browse repository at this point
Copy the full SHA 629ed07View commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1d87e46 - Browse repository at this point
Copy the full SHA 1d87e46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e41d9a - Browse repository at this point
Copy the full SHA 6e41d9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd01fa3 - Browse repository at this point
Copy the full SHA fd01fa3View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6dcc91a - Browse repository at this point
Copy the full SHA 6dcc91aView commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15a460f - Browse repository at this point
Copy the full SHA 15a460fView commit details
Commits on Oct 22, 2024
-
Improve Profile.Icon UI in settings (#17965)
## Summary of the Pull Request Improves the UI for the Profile.Icon setting by adding an "Icon Type" combo box. This allows the user to pick from multiple options: - None: sets the icon to "none" which is interpreted as no icon - Built-in Icon: presents a combo box that enumerates the Segoe MDL 2 assets - Emoji: presents a text box with a hint to open the emoji picker - File: presents a text box to input the path of the image to use Additionally, the rendered icon is displayed in the setting container. If "none", "none" is presented to the user (localized). ✅ Verified as accessible using Accessibility Insights #10000
Configuration menu - View commit details
-
Copy full SHA for 460b180 - Browse repository at this point
Copy the full SHA 460b180View commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8285dfb - Browse repository at this point
Copy the full SHA 8285dfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 230b9bc - Browse repository at this point
Copy the full SHA 230b9bcView commit details
Commits on Nov 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3a40272 - Browse repository at this point
Copy the full SHA 3a40272View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3ad287 - Browse repository at this point
Copy the full SHA c3ad287View commit details
Commits on Nov 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9df6b03 - Browse repository at this point
Copy the full SHA 9df6b03View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for e46ed40 - Browse repository at this point
Copy the full SHA e46ed40View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.