Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable colors and improve Profile.Icon in settings UI #17870

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Commits on Aug 26, 2024

  1. Configuration menu
    Copy the full SHA
    4fe421c View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Configuration menu
    Copy the full SHA
    15922b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    153d97e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    e3e0b93 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. temp commit 1

    carlos-zamora committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c3d2e98 View commit details
    Browse the repository at this point in the history
  2. temp commit 2

    carlos-zamora committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    629ed07 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. almost done!

    carlos-zamora committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1d87e46 View commit details
    Browse the repository at this point in the history
  2. polish!

    carlos-zamora committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6e41d9a View commit details
    Browse the repository at this point in the history
  3. code format

    carlos-zamora committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    fd01fa3 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. better color comparison

    carlos-zamora committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6dcc91a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    15a460f View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Improve Profile.Icon UI in settings (#17965)

    ## Summary of the Pull Request
    Improves the UI for the Profile.Icon setting by adding an "Icon Type"
    combo box. This allows the user to pick from multiple options:
    - None: sets the icon to "none" which is interpreted as no icon
    - Built-in Icon: presents a combo box that enumerates the Segoe MDL 2
    assets
    - Emoji: presents a text box with a hint to open the emoji picker
    - File: presents a text box to input the path of the image to use
    
    Additionally, the rendered icon is displayed in the setting container.
    If "none", "none" is presented to the user (localized).
    ✅ Verified as accessible using Accessibility Insights
    #10000
    carlos-zamora authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    460b180 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. apply feedback

    carlos-zamora committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    8285dfb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    230b9bc View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    3a40272 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c3ad287 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Configuration menu
    Copy the full SHA
    9df6b03 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    e46ed40 View commit details
    Browse the repository at this point in the history