Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SolidColorBrush to AcrylicBrush in MainPage.xaml #17198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlejandroBlanco2001
Copy link
Contributor

Summary of the Pull Request

In the MainPage.xaml, change the SolidColorBrush to AcrylicBrush to be able to alter the color of the panel when it cannot be rendered

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

In #12973, we changed the way of rendering the panel to use a SolidColorBrush with a transparent background. However, when this cannot be rendered, it causes an error of overlapping. Therefore, this change is to revert this panel to the original implementation introduced in #9752, using AcrylicBrush and setting the color to 'SystemChromeMediumLowColor' when it cannot be rendered.

Validation Steps Performed

  1. Open the Windows terminal App
  2. Set the width to <= 500px
  3. Open the Settings tab
  4. Check that the background is not longer overlapping.

image

PR Checklist

@AlejandroBlanco2001
Copy link
Contributor Author

@AlejandroBlanco2001 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@carlos-zamora carlos-zamora added the Needs-Discussion Something that requires a team discussion before we can proceed label May 30, 2024
@AlejandroBlanco2001
Copy link
Contributor Author

@carlos-zamora Any news on this PR? 😄

@DHowett
Copy link
Member

DHowett commented Oct 28, 2024

Hey @AlejandroBlanco2001! I'm so sorry that we let this sit - I think we marked it up to be discussed by the team, and I'm the one who had an objection. We forgot to take notes, follow up, and help you get this in.

That's on me.

My main concern is that it will make the settings look out of place on Windows 11. It's better than it being broken on Windows 10, but I was wondering if there was a way for us to use "Conditional Xaml" to make these resources work properly and look native on both 10 and 11.

@DHowett
Copy link
Member

DHowett commented Oct 28, 2024

@zadjii-msft has a thought as well: "Does the transparent background also cause an overlap on Windows 11? Because if so, condition XAML won't help"

@carlos-zamora carlos-zamora removed the Needs-Discussion Something that requires a team discussion before we can proceed label Oct 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-SettingsUI Anything specific to the SUI Product-Terminal The new Windows Terminal. labels Oct 28, 2024
@AlejandroBlanco2001
Copy link
Contributor Author

Hey @DHowett, I don't have Windows 11 on any of my machines, but I could check on a friend's PC today if you need that feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar and settings are shown at the same time
3 participants