Fix App user-agent merging#573
Open
heyitsaamir wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes how App constructs its internal HTTP client when the caller supplies client options, ensuring custom User-Agent values are merged (case-insensitively) instead of being overwritten or duplicated. This aligns App’s behavior with the existing Client.clone() header-merging semantics in @microsoft/teams.common.
Changes:
- Update
AppHTTP client initialization to useClient.clone()forUser-Agentmerging whenoptions.clientis aClientOptionsobject. - Add a regression test verifying case-insensitive merging when the caller provides
user-agentin lowercase.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/apps/src/app.ts | Uses new HttpClient(options.client).clone({ headers: { 'User-Agent': ... }}) to merge User-Agent instead of overwriting/duplicating it. |
| packages/apps/src/app.spec.ts | Adds a test asserting App’s UA is merged with a user-provided lowercase user-agent header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-Agentvalues get merged instead of stomped.user-agentTest plan