sync main into releases/core

[singhk97]

No description provided.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Sync of the main branch into releases/core. Major themes are: (1) introducing experimental Quoted-Reply and Targeted-Message (Prompt Preview) APIs across the Core/Apps SDK with matching tests and samples; (2) overhauling threading helpers (ConversationExtensions.ToThreadedConversationId / TeamsBotApplication.{SendAsync,ReplyAsync} and dropping ReplyToId-based URL routing); (3) consolidating BotAuthenticationHandler / MSAL configuration and moving several internal types to public; (4) reworking the Azure DevOps pipelines into a unified detect-then-build-test-pack flow with new shared templates; and (5) adding several new samples (Threading, Quoting, TargetedMessages, McpServer, ExtAIBot).

Changes:

• Add Quoted-Reply / Targeted-Message-Info entities, builders, extensions, JSON contexts, and tests; deprecate Activity.ToQuoteReply in favor of AddQuote/PrependQuote.
• Replace ReplyToId-based reply URL handling with ;messageid= threading helpers; rename Send/Reply → SendAsync/ReplyAsync (with shims) and add agenticIdentity parameters.
• Refactor BotAuthenticationHandler to use IOptionsMonitor<ManagedIdentityOptions> + named scopes, delete MsalConfigurationExtensions/BotClientOptions, expose BotHttpClient/BotRequestOptions/CoreActivity ctor publicly.
• Rebuild ADO pipelines (ci.yaml, publish.yaml, new shared build-test-pack.yaml); drop cd-core.yaml; update core.slnx/csproj packaging metadata.
• Add new samples and an MCP plugin auth gate (McpPluginOptions.RequireAuth); add streaming-writer MessageActivity-finalize overload; add AppOptions.AutoUserTokenLookup opt-out.

Reviewed changes

Copilot reviewed 144 out of 146 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
core/src/Microsoft.Teams.Core/ConversationClient.cs	Removes ReplyToId URL-append; exposes BotHttpClient publicly.
core/src/Microsoft.Teams.Core/Schema/ConversationExtensions.cs	New helpers ThreadId() / ToThreadedConversationId().
core/src/Microsoft.Teams.Core/Schema/CoreActivityBuilder.cs	Removes WithReplyToId.
core/src/Microsoft.Teams.Core/Schema/CoreActivity.cs	Constructor made public; ExperimentalTeamsTargeted suppression.
core/src/Microsoft.Teams.Core/Hosting/BotAuthenticationHandler.cs	Switches to IOptionsMonitor, named options, hardcoded scopes.
core/src/Microsoft.Teams.Core/Hosting/JwtExtensions.cs	Uses BotConfig.DefaultSectionName/BotConfig.Resolve.
core/src/Microsoft.Teams.Core/Hosting/MsalConfigurationExtensions.cs	Deleted.
core/src/Microsoft.Teams.Core/Hosting/BotClientOptions.cs	Deleted.
core/src/Microsoft.Teams.Core/Http/{BotHttpClient,BotRequestOptions}.cs	Made public.
core/src/Microsoft.Teams.Core/Schema/ConversationAccount.cs	Marks IsTargeted [Experimental].
core/src/Microsoft.Teams.Core/GlobalSuppressions.cs	Suppresses CA1054 on BotHttpClient.
core/src/Microsoft.Teams.Core/Microsoft.Teams.Core.csproj	Pkg metadata; drop InternalsVisibleTo for Apps/BotBuilder.
core/src/Microsoft.Teams.Core/Log.cs	New InferringUserAssignedManagedIdentity log; removed handler log.
core/src/Microsoft.Teams.Apps/TeamsBotApplication.cs	Adds SendAsync/ReplyAsync w/ agenticIdentity.
core/src/Microsoft.Teams.Apps/TeamsBotApplication.HostingExtensions.cs	Reorders AddBotApplication/AddBotClient.
core/src/Microsoft.Teams.Apps/TeamsStreamingWriter.cs	New MessageActivity finalize overload.
core/src/Microsoft.Teams.Apps/Schema/TeamsActivityBuilder.cs	Removes WithReplyToId; adds WithQuote/WithTargetedMessageInfo.
core/src/Microsoft.Teams.Apps/Schema/{TeamsChannelData,SuggestedAction}.cs	Adds FeedbackLoop/FeedbackType; SuggestedAction.Value ctor arg.
core/src/Microsoft.Teams.Apps/Schema/TeamsConversationAccount.cs	Wraps targeted access with #pragma warning.
core/src/Microsoft.Teams.Apps/Schema/TeamsActivityJsonContext.cs	Registers new entity types.
core/src/Microsoft.Teams.Apps/Schema/Entities/{QuotedReplyEntity,TargetedMessageInfoEntity}.cs	New entities.
core/src/Microsoft.Teams.Apps/Schema/Entities/Activity{Quoted,Targeted}*.cs	New extension helpers.
core/src/Microsoft.Teams.Apps/Schema/Entities/Entity.cs	Polymorphic deserialization for new entity types.
core/src/Microsoft.Teams.Apps/Schema/Entities/CitationEntity.cs	Adds AddFeedback(string mode) overload.
core/src/Microsoft.Teams.Apps/Handlers/MessageFetchTaskHandler*.cs	New OnMessageFetchTask handler + value types.
core/src/Microsoft.Teams.Apps/Handlers/MessageSubmitActionHandler*.cs	New OnMessageSubmitFeedback handler + value type.
core/src/Microsoft.Teams.Apps/Handlers/InvokeHandler.Activity.cs	Adds MessageFetchTask invoke name.
core/src/Microsoft.Teams.Apps/Api/Clients/{ReactionClient,ConversationApiClient}.cs	Removes ExperimentalTeamsReactions gating.
core/src/Microsoft.Teams.Apps/Microsoft.Teams.Apps.csproj	Pkg metadata; new NoWarns.
core/src/Microsoft.Teams.Apps.BotBuilder/*	Pkg metadata; consolidates InternalsVisibleTo.
core/src/Directory.Build.props	Fixes packaged icon path.
core/samples/{Threading,Quoting,TargetedMessages,McpServer,ExtAIBot}/*	New samples.
core/samples/StreamingBot/Program.cs	Migrates to MessageActivity-based finalize.
core/samples/{TeamsBot,TabApp,CompatBot,PABot}/*	Misc. dependency / launchSettings updates.
core/test/Microsoft.Teams.Core.UnitTests/Schema/ConversationTests.cs	Tests for new helpers.
core/test/Microsoft.Teams.Core.UnitTests/*.csproj	Adds NoWarn for experimental.
core/test/Microsoft.Teams.Core.UnitTests/CoreActivityBuilderTests.cs	Drops WithReplyToId test.
core/test/Microsoft.Teams.Core.UnitTests/ConversationClientTests.cs	Removes ReplyToId-based send tests.
core/test/Microsoft.Teams.Apps.UnitTests/{PromptPreview,TeamsBotApplication,TeamsStreamingWriter}Tests.cs	New / extended tests.
core/test/IntegrationTests/IntegrationTests.csproj	Adjusts NoWarn.
core/test/msal-config-api/*	Deleted.
core/core.slnx	Adds new sample/test projects.
core/version.json, Microsoft.Teams.Apps/version.json	Version offsets / preview tag.
core/docs/Architecture.md	Cleans up config docs.
Libraries/Microsoft.Teams.Api/*	Adds QuotedReplyEntity / TargetedMessageInfoEntity, deprecates ToQuoteReply.
Libraries/Microsoft.Teams.Apps/*	Adds Quote/PrependQuote, auto-targeted-message-info, AutoUserTokenLookup.
Libraries/Microsoft.Teams.Apps.Testing/Plugins/TestPlugin.cs	Validates targeted-in-personal in fake.
Libraries/Microsoft.Teams.Plugins/.../McpPlugin.cs	New RequireAuth middleware.
Libraries/Microsoft.Teams.Plugins/.../AspNetCorePlugin*.cs	Validates targeted-in-personal; fixes Stream Close race.
Tests/Microsoft.Teams.*	New entity / quoted-reply / prompt-preview tests; adjusts NoWarn.
Samples/Samples.{Quoting,TargetedMessages,Reactions}/*	New / updated samples.
.azdo/{ci,publish,cd-core}.yaml + templates	Pipeline consolidation.
.github/ISSUE_TEMPLATE/*, README.md, CONTRIBUTING.md	Docs/issue-template updates.

Files not reviewed (2)

• Samples/Samples.Tab/Web/package-lock.json: Language not supported
• core/samples/TabApp/Web/package-lock.json: Language not supported

Comments suppressed due to low confidence (13)

core/src/Microsoft.Teams.Core/Schema/ConversationExtensions.cs:1

• ToThreadedConversationId is declared in a class named ConversationExtensions and intended to behave like an extension helper, but it is a plain static method (no this string modifier). Callers must invoke it as ConversationExtensions.ToThreadedConversationId(...) rather than fluent-style on a string/Conversation. Either add this string conversationId to make it a true extension method, or move it to a non-Extensions-suffixed static helper class. The README and Threading sample call it the long way, which signals the awkwardness.
  core/src/Microsoft.Teams.Core/Schema/ConversationExtensions.cs:1
• Splitting on ; and discarding everything after the first segment silently drops any non-messageid parameters that may exist on the conversation id (e.g. ;tenantId=... or future suffixes). If only stripping an existing messageid is intended, parse selectively (e.g. remove only the messageid=... segment) and re-join the remaining parts before appending the new messageid. Otherwise threading into a conversation that already carries other suffixes will lose them.
  core/src/Microsoft.Teams.Core/ConversationClient.cs:1
• Removing the ReplyToId block changes outbound routing: previously, sending an activity with ReplyToId set went to …/activities/{ReplyToId} (the Bot Framework REST endpoint for replying to a specific activity). After this change, that URL is no longer produced anywhere in the SDK, since WithReplyToId was also removed from the builder and TeamsActivityBuilder.WithConversationReference no longer stamps ReplyToId. Anyone whose code (or persisted state) still sets CoreActivity.ReplyToId will silently get a non-threaded reply. Consider either documenting this as a breaking behavior change in the release notes or keeping the URL append as a fallback when ReplyToId is set.
  core/src/Microsoft.Teams.Apps/Schema/TeamsActivityBuilder.cs:1
• WithConversationReference no longer copies the inbound Id into ReplyToId. Combined with the removal of the ReplyToId URL append in ConversationClient, any code that relied on the implicit reply behavior of TeamsStreamingWriter / streaming flows / generic Reply() patterns will now produce a top-level message instead of a threaded reply. This is a silent behavior regression for callers of WithConversationReference — please confirm intent and document.
  core/src/Microsoft.Teams.Apps/TeamsBotApplication.HostingExtensions.cs:1
• The order of AddBotApplication<TApp> and AddBotClient<ApiClient> was swapped without an inline comment explaining why. If this was a deliberate fix (e.g. registration order matters because AddBotApplication adds something AddBotClient depends on, or vice versa), add a short comment so future refactors don't undo it. If it's incidental, please leave a note that order is not significant.
  core/src/Microsoft.Teams.Apps/TeamsStreamingWriter.cs:1
• If _accumulated.Length == 0 and the caller does not pass final, final.Text becomes \"\", then the next check (string.IsNullOrEmpty(final.Text) && (final.Attachments == null || final.Attachments.Count == 0)) throws — which preserves the prior behavior. However, if a caller passes a MessageActivity whose Text is null and never appended any chunks, final.Text will also be set to \"\" and then throw. The error message says "provide attachments on the final MessageActivity", which is fine, but consider also recommending appending text — the current message implies attachments are the only escape hatch.
  core/src/Microsoft.Teams.Apps/Schema/Entities/ActivityQuotedReplyExtensions.cs:1
• These cref references point at Context{TActivity}.Reply / Context{TActivity}.Quote, which are types from the legacy SDK (Libraries/Microsoft.Teams.Apps), not the Core SDK where this file lives. The cref will resolve to nothing in this assembly's docs. Either remove the cref or point at the Core equivalents.
  core/src/Microsoft.Teams.Apps/Schema/Entities/ActivityQuotedReplyExtensions.cs:1
• PrependQuote is named for the placement of the placeholder in the text (it is prepended), but the entity is also inserted at index 0 of the entities list. Order of Entities is generally not significant, but AddQuote appends to the entity list. The asymmetry isn't obvious and could surprise callers iterating entities by index. Consider documenting this on the method or aligning behavior with AddQuote.
  core/src/Microsoft.Teams.Apps/Schema/Entities/TargetedMessageInfoEntity.cs:1
• Combining required with a getter that throws bypasses the compile-time guarantee required provides. If a caller deserializes an inbound activity that lacks messageId, code reading MessageId will throw at unpredictable points. Consider returning a nullable string? instead and surfacing the missing-field condition explicitly to callers, or implementing IJsonOnDeserialized to fail-fast at deserialization.
  core/src/Microsoft.Teams.Core/Hosting/BotAuthenticationHandler.cs:1
• Switching from IOptions<ManagedIdentityOptions> to IOptionsMonitor<ManagedIdentityOptions> plus moving authenticationOptionsName to the second constructor parameter is a breaking change to anyone constructing this handler directly (the type was internal sealed, but BotHttpClient is now public and constructs handlers indirectly). Confirm no external code instantiates this and consider providing a transitional ctor overload if any does.
  core/src/Microsoft.Teams.Apps/Schema/TeamsChannelData.cs:1
• The doc says "Must not coexist with FeedbackLoopEnabled" but nothing in the code enforces this — both properties are independent setters. AddFeedback(string mode) carefully nulls FeedbackLoopEnabled when setting FeedbackLoop, but a caller setting both manually has no guardrail. Consider validating in serialization or adding an analyzer/runtime check, otherwise the documentation contract is silently violable.
  Tests/Microsoft.Teams.Api.Tests/Entities/QuotedReplyEntityTests.cs:1
• Use Assert.False(entity.QuotedReply.IsReplyDeleted) / Assert.True(entity.QuotedReply.ValidatedMessageReference) instead of Assert.Equal(false, ...). The former matches xUnit guidance and avoids boxing of nullable bools through the Equal(object, object) overload (which can produce confusing failure messages on null).
  core/test/Microsoft.Teams.Apps.UnitTests/PromptPreviewTests.cs:1
• There are no tests for the case where the inbound Activity.Id is null but Recipient.IsTargeted == true (which is allowed by the SDK). The auto-populate code in Context.Send skips on null Id, but no test asserts this path. Add a test case to lock the behavior in.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.