Make core packages compliant with Microsoft NuGet authoring requirements#513
Merged
Conversation
- Add PackageProjectUrl in core/src/Directory.Build.props - Fix broken PackageIcon path (missing $ on MSBuildThisFileDirectory) and correct relative path to core/bot_icon.png - Rename Description -> PackageDescription and add PackageTags on the three core csproj files (Core, Apps, Apps.BotBuilder) - Add MIT license/copyright header comments to each csproj - Bump versionHeightOffset in core/version.json and Apps/version.json Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Brings the three core NuGet packages into compliance with Microsoft's NuGet authoring requirements by adding required metadata, fixing the broken PackageIcon packing path, and adding MIT license header comments to each csproj. Also bumps version height offsets so package versions remain stable across the new commits.
Changes:
- Add
PackageProjectUrl,PackageTags, MIT/copyright header comments, and renameDescription→PackageDescriptionfor the three core packages. - Fix the
bot_icon.pngpacking path incore/src/Directory.Build.props(previously a literal(MSBuildThisFileDirectory)token with too many../segments). - Bump
versionHeightOffsetincore/version.jsonandcore/src/Microsoft.Teams.Apps/version.jsonto absorb the new commits.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/version.json | Decrement versionHeightOffset from -3 to -6 to keep version stable across new commits. |
| core/src/Microsoft.Teams.Apps/version.json | Add versionHeightOffset: -3 for the Apps package. |
| core/src/Directory.Build.props | Add PackageProjectUrl; fix PackageIcon None Include path to use $(MSBuildThisFileDirectory)../bot_icon.png. |
| core/src/Microsoft.Teams.Core/Microsoft.Teams.Core.csproj | Add MIT header, rename Description → PackageDescription, add PackageTags. |
| core/src/Microsoft.Teams.Apps/Microsoft.Teams.Apps.csproj | Same metadata cleanup as above. |
| core/src/Microsoft.Teams.Apps.BotBuilder/Microsoft.Teams.Apps.BotBuilder.csproj | Same metadata cleanup as above. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rido-min
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.Teams.Core,Microsoft.Teams.Apps,Microsoft.Teams.Apps.BotBuilder) into compliance with the Microsoft NuGet package authoring requirements.PackageProjectUrl, fixes a brokenPackageIconpacking path incore/src/Directory.Build.props, renamesDescription→PackageDescription, addsPackageTags, and adds MIT license/copyright header comments to each csproj.versionHeightOffsetincore/version.jsonandcore/src/Microsoft.Teams.Apps/version.json.Compliance gaps addressed
PackageProjectUrlhttps://microsoft.github.io/teams-sdkPackageIconpacking(MSBuildThisFileDirectory)../../../../bot_icon.png)$(MSBuildThisFileDirectory)../bot_icon.pngPackageDescriptionDescriptionPackageDescriptionPackageTagsmicrosoft;teams;msteams;copilot;ai;adaptive-cards;apps;botsKnown follow-up (not in this PR)
core/bot_icon.pngis 75x75; the authoring spec recommends 100x100 (with clean downscaling to 32/48/64/128).SignAssembly+key.snk) — not adopted in core yet, matches existing core stance.Test plan
dotnet packthe three core projects locally and inspect the produced.nupkgto confirmbot_icon.pngandREADME.mdare packed at the root and the metadata fields render correctly.nuget.exe verifystep in CI.