Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift the pandas dependency to the model packages #94

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

kmaziarz
Copy link
Contributor

@kmaziarz kmaziarz commented Jun 7, 2024

The pandas dependency was so far part of our conda environment without any pin, but it seems more recent versions can cause some issues in LocalRetro when combined with rdkit, causing CI to fail. Given that pandas is available from PyPI, this PR removes the dependency from the environment and instead adds it (with a <2.2 constraint) to the syntheseus-local-retro package.

@kmaziarz kmaziarz requested a review from AustinT June 7, 2024 13:25
Copy link
Collaborator

@AustinT AustinT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmaziarz kmaziarz merged commit feb813d into main Jun 10, 2024
9 checks passed
@kmaziarz kmaziarz deleted the kmaziarz/pandas branch June 10, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants