Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running the security pipeline on every PR #12

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

kmaziarz
Copy link
Contributor

@kmaziarz kmaziarz commented Jul 11, 2023

The security pipeline defined in azure_pipelines/code-security-analysis.yml is scheduled to run weekly as required by Microsoft policy. However, it also seems to run on all PRs, which is unnecessary. This PR changes the pipeline's configuration to only do the scheduled runs and not run as part of CI.

@kmaziarz kmaziarz requested a review from fiberleif July 11, 2023 10:33
@kmaziarz kmaziarz requested a review from AustinT July 11, 2023 11:13
Copy link
Collaborator

@AustinT AustinT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems in this PR, but I also have no way to check that this accomplishes what we intend it to accomplish. If you have looked into it then I will trust you Kris!

@kmaziarz
Copy link
Contributor Author

I don't see any problems in this PR, but I also have no way to check that this accomplishes what we intend it to accomplish. If you have looked into it then I will trust you Kris!

I can't be 100% sure, but if you look at the checks ran on this PR, the security pipeline (called microsoft.syntheseus) is no longer there, while it was there on all previous PRs, so hopefully my changes are doing the right thing 🙂

@kmaziarz kmaziarz merged commit 4049576 into main Jul 11, 2023
3 checks passed
@kmaziarz kmaziarz deleted the kmaziarz/security-pipeline branch July 11, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants