[proxy](6/n) proxy utility headers and fix a potential bug #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchrodingerZhu
force-pushed
the
proxy-uility
branch
4 times, most recently
from
c73fdc0 to
fb47e88
Compare
SchrodingerZhu
force-pushed
the
proxy-uility
branch
from
fb47e88 to
ee52677
Compare
SchrodingerZhu
commented
Dec 21, 2024
| @@ -117,8 +120,16 @@ namespace snmalloc | |||
| { | |||
| static_assert(B::wildness == capptr::dimension::Wildness::Wild); | |||
|
|
|||
| static const size_t sz = sizeof( | |||
| std::conditional<std::is_same_v<std::remove_cv<T>, void>, void*, T>); | |||
There was a problem hiding this comment.
I guess this was written wrongly. I fixed that in this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #720