Object stats #616
Object stats #616
Conversation
snmalloc::RemoteDeallocCache::remote_inflight tracks the amount of bytes that are inbetween threads.
There was a problem hiding this comment.
Generally looks quite nice. ISTR snmalloc of old had the ability to conditionally keep stats or not; perhaps it would be worth having an empty implementation of the Stat and MonotoneStat interfaces and either templating or having a namespace snmalloc-scoped using to pick between them?
src/snmalloc/mem/globalalloc.h
Outdated
| @@ -87,6 +87,10 @@ namespace snmalloc | |||
| } | |||
| } | |||
|
|
|||
| if ( | |||
| result == nullptr && RemoteDeallocCache::remote_inflight.get_curr() != 0) | |||
There was a problem hiding this comment.
Something has happened (TM) with the syntax there. Can this be a SNMALLOC_ASSERT_MSG?
There was a problem hiding this comment.
Generally looks quite nice. ISTR snmalloc of old had the ability to conditionally keep stats or not; perhaps it would be worth having an empty implementation of the Stat and MonotoneStat interfaces and either templating or having a namespace snmalloc-scoped using to pick between them?
I was going to profile to see how much the operations cost. If they are noticeable, then I will macro it away as you suggest. |
This adds some statistic for tracking
The per sizeclass statistics are tracked per allocator, and a racy read is done to combine the results for displaying.
These statistics were used to debug #615 to calculate the fragmentation.
The displayed statistics are intended for post processing to calculate the fragmentation/utilisation.
The interface just prints the results using
message. This could be improved with a better logging infrastructure.