Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: fix a bug in the Makefile for checking if uv is installed or not #9763

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Python: fix a bug in the Makefile for checking if uv is installed or not #9763

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7da915c
Check if `uv` exists or not
Nov 19, 2024
69c3c4f
Add ifdef for verbose mode
Nov 20, 2024
6d0ddce
use ifneq, fix bug
Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
SHELL = /bin/bash

.PHONY: help install clean build
ifndef VERBOSE
.SILENT:
endif
all: install

ifeq ($(PYTHON_VERSION),)
Expand Down Expand Up @@ -37,7 +39,7 @@ install:
UV_VERSION = $(shell uv --version 2> /dev/null)
install-uv:
# Check if uv is installed
ifdef UV_VERSION
ifneq ($(UV_VERSION),)
echo "uv found $(UV_VERSION)"
echo "running uv update"
uv self update
Expand Down
Loading