Skip to content

fix(mistral): remove accidental tuple wrapping of CompletionUsage in metadata #13676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frankgoldfish wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −5
Open

fix(mistral): remove accidental tuple wrapping of CompletionUsage in metadata #13676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions python/semantic_kernel/connectors/ai/mistral_ai/services/mistral_ai_chat_completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,9 @@ def _get_metadata_from_response(self, response: ChatCompletionResponse | Complet
}
# Check if usage exists and has a value, then add it to the metadata
if hasattr(response, "usage") and response.usage is not None:
metadata["usage"] = (
CompletionUsage(
prompt_tokens=response.usage.prompt_tokens,
completion_tokens=response.usage.completion_tokens,
),
metadata["usage"] = CompletionUsage(
prompt_tokens=response.usage.prompt_tokens,
completion_tokens=response.usage.completion_tokens,
)
Comment on lines 253 to 257
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug fix changes the shape of metadata["usage"] (tuple -> CompletionUsage), but there is no regression test asserting the type/attributes of metadata["usage"] on returned ChatMessageContent / streaming chunks. Add a unit test that verifies response.metadata["usage"] is a CompletionUsage instance and that prompt_tokens/completion_tokens are accessible to prevent the tuple-wrapping bug from reappearing.

Copilot uses AI. Check for mistakes.

return metadata
Expand Down
Loading