[rush] Rename the subspace pnpmfileSettings file to globalPnpmfileSettings.json to avoid overwriting the original pnpmfileSettings.json

[fzxen]

Summary

This MR rename subspace pnpmfileSettings file to globalPnpmfileSettings.json, because subspace pnpmfileSettings overrides original pnpmfileSettings and they have different data structures.

subspace pnpmfileSettings

rushstack/libraries/rush-lib/src/logic/pnpm/IPnpmfile.ts

Lines 34 to 39 in e64a1e5

	export interface ISubspacePnpmfileShimSettings {
	semverPath: string;
	workspaceProjects: Record<string, IWorkspaceProjectInfo>;
	subspaceProjects: Record<string, IWorkspaceProjectInfo>;
	userPnpmfilePath?: string;
	}

original pnpmfileSettings

rushstack/libraries/rush-lib/src/logic/pnpm/IPnpmfile.ts

Lines 13 to 22 in e64a1e5

	export interface IPnpmfileShimSettings {
	semverPath: string;
	allPreferredVersions: { [dependencyName: string]: string };
	allowedAlternativeVersions: { [dependencyName: string]: ReadonlyArray<string> };
	/**
	* The versions of all packages that are part of the workspace.
	*/
	workspaceVersions: Record<string, string>;
	userPnpmfilePath?: string;
	}

Due to the missing preferredVersion information in subspace pnpmfileSettings file, the preferredVersion does not take effect when the subspace is enabled.

Fixes #5118

Details

After debugging rush-lib, I found that pnpmfileSettings.json will be written twice.

First time:

rushstack/libraries/rush-lib/src/logic/pnpm/PnpmfileConfiguration.ts

Lines 80 to 83 in 438525c

	// Write the settings file used by the shim
	await JsonFile.saveAsync(pnpmfileShimSettings, path.join(targetDir, 'pnpmfileSettings.json'), {
	ensureFolderExists: true
	});

Second time:

rushstack/libraries/rush-lib/src/logic/pnpm/SubspacePnpmfileConfiguration.ts

Lines 50 to 56 in 438525c

	await JsonFile.saveAsync(
	subspaceGlobalPnpmfileShimSettings,
	path.join(targetDir, 'pnpmfileSettings.json'),
	{
	ensureFolderExists: true
	}
	);

The second write operation will overwrite the first write content. And pnpmfileSettings.json is read once by global-pnpmfile.cjs and pnpmfile.cjs respectively.

Maybe we should distinguish the file names written twice, one is named pnpmfileSettings.json and the other named is globalPnpmfileSettings.json.

How it was tested

Impacted documentation