Deduplicate WebClient. #5025
Merged
Deduplicate WebClient. #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L,
dmichon-msft,
TheLarkInn and
patmill
as code owners
D4N14L
approved these changes
Dec 4, 2024
iclanton
force-pushed
the
deduplicate-webclient
branch
from
4b6764d to
8b6ae97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deduplicate WebClient and remove some dependencies on
node-fetch.Details
This PR adds
lib/*stubs for chunk-only modules inrush-liband makes use of one of those (WebClient) in plugins.How it was tested
This should be published as a prerelease to be tested.
Impacted documentation
None.