Create Dedicated Pipeline to Create Tarball Packages #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atingmicrosoft
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
Comment on lines
+40
to
+42
| - output: pipelineArtifact | ||
| targetPath: $(Build.ArtifactStagingDirectory)/published-versions | ||
| artifactName: published-versions |
There was a problem hiding this comment.
This is how you publish a pipeline artifact. There should be another entry like this pointing to the output folder from the rush publish --pack command; that will produce your artifact for consumption in the separate publish pipeline.
Comment on lines
12
to
16
| - name: Publish | ||
| ${{ if eq(parameters.TestRun, false) }}: | ||
| value: '--publish' | ||
| ${{ else }}: | ||
| value: '' |
There was a problem hiding this comment.
Suggested change
| - name: Publish | |
| ${{ if eq(parameters.TestRun, false) }}: | |
| value: '--publish' | |
| ${{ else }}: | |
| value: '' |
Comment on lines
60
to
61
| parameters: | ||
| Publish: $(Publish) |
There was a problem hiding this comment.
Suggested change
| parameters: | |
| Publish: $(Publish) |
| default: '' | ||
|
|
||
| steps: | ||
| - script: 'node common/scripts/install-run-rush.js publish $(Publish) --pack --include-all --release-folder esrp-release' |
There was a problem hiding this comment.
The folder specified under --release-folder should correspond to an output entry in templateContext.outputs.
| @@ -0,0 +1,59 @@ | |||
| parameters: | |||
| - name: TestRun | |||
| displayName: 'Test Run (Will Not Create Tar Files for Rushstack)' | |||
There was a problem hiding this comment.
Considering that publishing the artifact does not have any direct consequences, there's no reason to have a dryRun option for this pipeline.
| artifactName: published-versions | ||
| - output: pipelineArtifact | ||
| targetPath: $(Build.ArtifactStagingDirectory)/packages | ||
| artifactNames: packages |
There was a problem hiding this comment.
Suggested change
| artifactNames: packages | |
| artifactName: packages |
Comment on lines
2
to
7
| - bash: > | ||
| mkdir -p $(Build.ArtifactStagingDirectory)/packages | ||
| displyName: 'Create Folder for Packages File' | ||
|
|
||
| - script: 'node common/scripts/install-run-rush.js publish --publish --pack --include-all --release-folder esrp-release' | ||
| displayName: 'Create TarBallz folder for Rush packages' |
There was a problem hiding this comment.
Suggested change
| - bash: > | |
| mkdir -p $(Build.ArtifactStagingDirectory)/packages | |
| displyName: 'Create Folder for Packages File' | |
| - script: 'node common/scripts/install-run-rush.js publish --publish --pack --include-all --release-folder esrp-release' | |
| displayName: 'Create TarBallz folder for Rush packages' | |
| - script: | | |
| mkdir -p $(Build.ArtifactStagingDirectory)/packages | |
| node common/scripts/install-run-rush.js publish --publish --pack --include-all --release-folder "$(Build.ArtifactStagingDirectory)/packages" | |
| displayName: 'Pack tarballs' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Creates a pipeline dedicated to packaging rushstack packges as tarballs.
Details
Creating a separate pipeline would not interfere with normal npm packaging.
How it was tested
Tested by running the
rush publishcommand use to create tarballs locally.Impacted documentation
NA