-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knarwani/fix workspace resolution issue #2550
Closed
krishna8770
wants to merge
3
commits into
microsoft:main
from
krishna8770:knarwani/fix-workspace-resolution-issue
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -167,6 +167,7 @@ describe("resolveCapabilities()", () => { | |
mergePresets( | ||
["microsoft/react-native", "mock-custom-profiles-module"], | ||
process.cwd(), | ||
{}, | ||
makeMockResolver("mock-custom-profiles-module") | ||
), | ||
["[email protected] || 0.63 || 0.64"] | ||
|
@@ -232,6 +233,7 @@ describe("resolveCapabilities()", () => { | |
mergePresets( | ||
["microsoft/react-native", "mock-meta-package"], | ||
process.cwd(), | ||
{}, | ||
makeMockResolver("mock-meta-package") | ||
), | ||
["[email protected]"] | ||
|
@@ -277,6 +279,7 @@ describe("resolveCapabilities()", () => { | |
mergePresets( | ||
["microsoft/react-native", "mock-meta-package-loop"], | ||
process.cwd(), | ||
{}, | ||
makeMockResolver("mock-meta-package-loop") | ||
), | ||
["[email protected]"] | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for working on this. I think it's a good start, but I have several issues with this:
getManifests()
.getPackageInfos
eagerly reads all packages to returnPackageInfos
. We may not even need them. This should be done lazily.parse-package-name
andworkspace-tools
. If we're missing anything, we should consider adding them totools-node
ortools-workspaces
instead.Keep in mind that we have users running align-deps as a Git hook. This command cannot be reading the whole monorepo before the checks even start. We need to postpone work as much as possible until we actually need them.
We should be passing the list of manifests to the command itself and then to
loadPreset
.loadPreset
will try finding the package from the monorepo if it's there. This result should be cached so that we only perform this once. If we are passing a "context" object with all the information, we can easily add caching to it. This will require us to modify the signature of commands, but we should be able to make it backwards compatible: