Skip to content

Conversation

@nddq
Copy link
Member

@nddq nddq commented Feb 11, 2026

Description

  • Update Go base images and build toolchain in Dockerfiles (controller, operator, cli, test)
  • Rename Windows Dockerfile final stage to agent-win for correct Docker target resolution
  • Fix CGO_ENABLED handling in test image Dockerfile for BPF code generation
  • Add _cprog to golangci-lint excluded paths to avoid linting eBPF C source files
  • Update Makefile, CI workflows, devcontainer, and .gitignore for Cilium v1.19 compatibility

PR 2 of 7 for Cilium v1.19 upgrade.

Related Issue

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

  • Verify Windows Docker builds complete successfully with renamed agent-win stage
  • Verify Linux Docker builds complete with updated base images
  • Verify golangci-lint passes without errors on _cprog directories
  • Verify test image builds and runs go generate successfully

Additional Notes

None.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@nddq nddq requested a review from a team as a code owner February 11, 2026 08:04
@nddq nddq requested review from kamilprz and ritwikranjan and removed request for a team February 11, 2026 08:04
@nddq nddq force-pushed the cilium/v1.19-pr2-build branch 2 times, most recently from e8c673c to d2a0996 Compare February 11, 2026 16:09
@nddq nddq closed this Feb 11, 2026
@nddq nddq reopened this Feb 11, 2026
@nddq nddq force-pushed the cilium/v1.19-pr2-build branch from d2a0996 to 942e537 Compare February 11, 2026 20:46
- Bump Go base images to 1.25.7 across all Dockerfiles
- Add ARG BUILDPLATFORM before first FROM in Windows Dockerfiles
- Fix CGO_ENABLED handling and use -run bpf2go in test image Dockerfile
- Add _cprog to golangci-lint excluded paths
- Update Makefile, CI workflows, devcontainer, and .gitignore

Signed-off-by: Quang Nguyen <[email protected]>
@nddq nddq force-pushed the cilium/v1.19-pr2-build branch from 942e537 to 11a6a74 Compare February 13, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant