Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): add custom error handler for Kubernetes API errors #1024

Merged
merged 14 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ func (r *endpointReconciler) handlePodUpsert(ctx context.Context, newPEP *PodEnd
// May end up getting another endpoint ID below if we try to create the CEP below.
// No downside to this.

if !k8serrors.IsNotFound(err) && err != nil {
ritwikranjan marked this conversation as resolved.
Show resolved Hide resolved
if !k8serrors.IsNotFound(err) {
r.l.WithError(err).WithFields(logrus.Fields{
"podKey": newPEP.key.String(),
"pep": newPEP,
Expand Down
29 changes: 29 additions & 0 deletions pkg/k8s/watcher_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@ package k8s

import (
"context"
"strings"
"sync"
"time"

"k8s.io/apimachinery/pkg/util/runtime"

agentK8s "github.com/cilium/cilium/daemon/k8s"
"github.com/cilium/cilium/pkg/hive/cell"
"github.com/cilium/cilium/pkg/ipcache"
Expand All @@ -17,6 +20,13 @@ import (
"github.com/cilium/cilium/pkg/option"
)

func init() {
// Register custom error handler for the watcher
runtime.ErrorHandlers = []func(error){
retinaK8sErrorHandler,
}
}

const (
K8sAPIGroupCiliumEndpointV2 = "cilium/v2::CiliumEndpoint"
K8sAPIGroupServiceV1Core = "core/v1::Service"
Expand Down Expand Up @@ -92,3 +102,22 @@ func Start(ctx context.Context, k *watchers.K8sWatcher) {
<-syncdCache
logger.Info("Kubernetes watcher synced")
}

// retinaK8sErrorHandler is a custom error handler for the watcher
// that logs the error and tags the error to easily identify
func retinaK8sErrorHandler(e error) {
errStr := e.Error()
switch {
case strings.Contains(errStr, "Failed to watch *v1.Node"):
logger.WithField("actualError", errStr).Error("Potentially Network Error coming from K8s API Server failing to watch Nodes")
case strings.Contains(errStr, "Failed to watch *v2.CiliumEndpoint"):
logger.WithField("actualError", errStr).Error("Potentially Network Error coming from K8s API Server failing to watch CiliumEndpoints")
case strings.Contains(errStr, "Failed to watch *v1.Service"):
logger.WithField("actualError", errStr).Error("Potentially Network Error coming from K8s API Server failing to watch Services")
case strings.Contains(errStr, "Failed to watch *v2.CiliumNode"):
logger.WithField("actualError", errStr).Error("Potentially Network Error coming from K8s API Server failing to watch CiliumNodes")

default:
k8s.K8sErrorHandler(e)
}
}
Loading