-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Fabric] Fix UIA_LiveSettingPropertyId to use VT_I4 datatype instead of VT_BSTR #15438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric] Fix UIA_LiveSettingPropertyId to use VT_I4 datatype instead of VT_BSTR #15438
Conversation
…of VT_BSTR Fixes microsoft#15050 Use GetLiveSetting() conversion function to properly convert accessibilityLiveRegion string values to long (VT_I4) datatype as required by UIA_LiveSettingPropertyId.
|
@microsoft-github-policy-service agree |
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vineethkuttan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a manually created file, this won't work. Delete this
Run yarn change in your local repo, follow this doc
Looks like the format is ok. Its likely ok as is. It does look like you are missing parts of your changes though. |
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vineethkuttan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes added
vineethkuttan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes added
sundaramramaswamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Fixes the UIA_LiveSettingPropertyId event to use the correct VT_I4 datatype instead of VT_BSTR for accessibility live region updates in Fabric. This ensures compliance with UIA requirements and improves accessibility event handling.
Type of Change
Erase all that don't apply.
Why
The motivation for this change is to resolve an issue where the UIA_LiveSettingPropertyId event was being raised with the wrong datatype (VT_BSTR instead of VT_I4). This caused accessibility tools to misinterpret the live region setting, impacting screen reader behavior and overall accessibility compliance.
Resolves #15050
What
CompositionViewComponentView.cppto use theGetLiveSetting()conversion function forUIA_LiveSettingPropertyId.Screenshots
N/A (no UI changes)
Testing
Optional: Ran local builds and checked accessibility event output for correctness.
Changelog
Should this change be included in the release notes: yes
Release Notes Summary:
Fixes accessibility event datatype for UIA_LiveSettingPropertyId in Fabric, ensuring proper screen reader support and UIA compliance.
Microsoft Reviewers: Open in CodeFlow