Implement scrollEnabled property for TextInput in Fabric architecture #14888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
scrollEnabled
property for TextInput components in the Fabric architecture, bringing feature parity with the Paper implementation.Problem
The
scrollEnabled
property was available in React Native Windows Paper implementation viaTextInputViewManager
but was missing from the Fabric implementation. While the property was already defined inWindowsTextInputProps
, it wasn't being used in theWindowsTextInputComponentView
.Solution
Modified the
TxGetScrollBars
method in theCompTextHost
class to respect thescrollEnabled
property:Behavior
scrollEnabled={false}
: No scroll bars are displayed, effectively disabling scrollingscrollEnabled={true}
(default): Uses existing logic based on multiline propertyThis matches the behavior described in the React Native documentation and mirrors the Paper implementation approach.
Testing
Fixes #13130.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io
/usr/local/bin/node install.mjs
(dns block)https://storage.googleapis.com/chrome-for-testing-public/130.0.6723.116/linux64/chrome-headless-shell-linux64.zip
/usr/local/bin/node install.mjs
(http block)https://storage.googleapis.com/chrome-for-testing-public/130.0.6723.116/linux64/chrome-linux64.zip
If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.