-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[react-native-windows] Use new LongLivedObject.h header namespace #14839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[react-native-windows] Use new LongLivedObject.h header namespace #14839
Conversation
@acoates-ms / @vmoroz > Could you take a look at this change? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Hi @christophpurrer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs yarn change
to get the change files to verify it builds, but looks okay to me otherwise.
Thanks @jonthysell > I did not know that. |
This header moved 2 another package in 2020
58da0eb
to
f5953df
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Summary: Changelog: [Internal] RN-Windows has been updated > microsoft/react-native-windows#14839 Differential Revision: D78312252
) Summary: Changelog: [Internal] RN-Windows has been updated > microsoft/react-native-windows#14839 Differential Revision: D78312252
Description
This header moved to another package in 2022
Type of Change
Why
We want to delete the header file under the old location
What
No functional change
Screenshots
NA
Testing
CI jobs
Changelog
no_
Microsoft Reviewers: Open in CodeFlow