Skip to content

[react-native-windows] Use new LongLivedObject.h header namespace #14839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

christophpurrer
Copy link
Contributor

@christophpurrer christophpurrer commented Jul 3, 2025

Description

This header moved to another package in 2022

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

We want to delete the header file under the old location

What

No functional change

Screenshots

NA

Testing

CI jobs

Changelog

no_

Microsoft Reviewers: Open in CodeFlow

@christophpurrer christophpurrer requested a review from a team as a code owner July 3, 2025 22:43
@christophpurrer
Copy link
Contributor Author

@acoates-ms / @vmoroz > Could you take a look at this change?

@anupriya13
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@anupriya13
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@vineethkuttan
Copy link
Contributor

Hi @christophpurrer
can you run yarn change from your local repo and push after that. After that step only we can run our pipeline

Guidelines for it

Copy link
Contributor

@jonthysell jonthysell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs yarn change to get the change files to verify it builds, but looks okay to me otherwise.

@christophpurrer
Copy link
Contributor Author

Needs yarn change to get the change files to verify it builds, but looks okay to me otherwise.

Thanks @jonthysell > I did not know that.

@anupriya13
Copy link
Contributor

/azp run

@anupriya13 anupriya13 self-assigned this Jul 16, 2025
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@anupriya13 anupriya13 added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jul 16, 2025
@anupriya13 anupriya13 enabled auto-merge (squash) July 16, 2025 04:22
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Jul 16, 2025
Summary:
Changelog: [Internal]

RN-Windows has been updated > microsoft/react-native-windows#14839

Differential Revision: D78312252
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Jul 16, 2025
)

Summary:

Changelog: [Internal]

RN-Windows has been updated > microsoft/react-native-windows#14839

Differential Revision: D78312252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants