Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fetch integration test handle UTF-8 content #13551

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JunielKatarn
Copy link
Contributor

@JunielKatarn JunielKatarn commented Aug 8, 2024

Description

Update the content and remote endpoint for the fetch Desktop integration test.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

  • There is no current test for fetch / Blob implicit non-ASCII text response handling.

What

  • Validates UTF-8 non-ASCII content when using fetch.
  • Shifts test to local web server.

Related to OfficeDev/office-js#4736

Testing

  • Updated Fetch Desktop integration test.
Microsoft Reviewers: Open in CodeFlow

- Move test away from external endpoints (uses test web server)
- Validate UTF-8 `fetch` handling
@JunielKatarn JunielKatarn marked this pull request as draft August 10, 2024 00:22
auto-merge was automatically disabled August 10, 2024 00:22

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant