Remove usage of RestoreUseStaticGraphEvaluation #11509
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JunielKatarn If this change requires VS >= 17.5, can you update the dependency checks to bump the min VS version? It's currently set to |
Will do, though, I want to do more manual testing. |
|
What worked in 17.5 broke in 17.5. So maybe still worth removing all-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop using experimental restore graph evaluation.
Type of Change
Why
Some apps consuming Microsoft.ReactNative have found issues when
RestoreUseStaticGraphEvaluationis enabled (MSRN sets it automatically when building inside Visual Studio).It seems the bug that caused an erratic build behavior inside Visual Studio 17.x is no longer happening as of version 17.5.
Such behavior was fixed by setting the property being removed by this PR.
What
Remove all instances where
RestoreUseStaticGraphEvaluationis set to true.Testing
Manually building inside Visual Studio.
Microsoft Reviewers: Open in CodeFlow