Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(macos): temporarily disable test step due to random failures #2179

Merged
merged 1 commit into from
Aug 14, 2024
Merged

ci(macos): temporarily disable test step due to random failures #2179

merged 1 commit into from
Aug 14, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Aug 14, 2024 •
edited
Loading

Description

Temporarily disable test step due to random failures:

Testing failed:
  ReactTestApp (14119) encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted. (Underlying Error: Crash: ReactTestApp (14119) __55-[RCTDevLoadingView showMessage:color:backgroundColor:]_block_invoke. libsystem_c.dylib: abort() called))

** TEST EXECUTE FAILED **

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

n/a

@tido64 tido64 requested a review from Saadnajmi August 14, 2024 14:45
@tido64 tido64 requested a review from JasonVMo as a code owner August 14, 2024 14:45
@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels Aug 14, 2024
@tido64
Copy link
Member Author

tido64 commented Aug 14, 2024

Issue filed upstream: microsoft/react-native-macos#2163

Saadnajmi
Saadnajmi reviewed Aug 14, 2024
View reviewed changes
.github/workflows/build.yml
Comment on lines -390 to +391
if: ${{ steps.affected.outputs.macos != '' && github.event_name != 'schedule' }}
# Temporarily disabled due to random failures
if: false # ${{ steps.affected.outputs.macos != '' && github.event_name != 'schedule' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you normally track with a Github issue or a TODO or anything like that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2180

@tido64 tido64 mentioned this pull request Aug 14, 2024
Open
@tido64 tido64 merged commit 6bd81fb into trunk Aug 14, 2024
30 checks passed
@tido64 tido64 deleted the tido/disable-macos-test branch August 14, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @Saadnajmi