Strengthen check for inference type loops #2448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updats the check we have in type inference to ensure an inference type is not bound to another type that includes itself. The previous check worked for simple cases where the target type directly contained the inference type, but fails to catch recursion where the target type contained inference types that indicrectly pointed to the original inference type through the current type inference solution. With this check in place, we can now explicitly give an error when a recursive type is detected. Fixes #2426
minestarks
approved these changes
May 23, 2025
| @@ -2230,5 +2230,43 @@ mod given_interpreter { | |||
| "#]], | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn fuzz_2426() { | |||
There was a problem hiding this comment.
There's got to be a better name. recursive_type_constraint maybe?
Comment on lines
+2245
to
+2253
| match Interpreter::new( | ||
| sources, | ||
| PackageType::Lib, | ||
| TargetCapabilityFlags::all(), | ||
| LanguageFeatures::default(), | ||
| store, | ||
| &[(std_id, None)], | ||
| ) { | ||
| Ok(_) => panic!("interpreter should fail with error"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updats the check we have in type inference to ensure an inference type is not bound to another type that includes itself. The previous check worked for simple cases where the target type directly contained the inference type, but fails to catch recursion where the target type contained inference types that indicrectly pointed to the original inference type through the current type inference solution. With this check in place, we can now explicitly give an error when a recursive type is detected.
Fixes #2426