Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes found during bash #1916

Merged
merged 10 commits into from
Sep 18, 2024
Merged

Bug fixes found during bash #1916

merged 10 commits into from
Sep 18, 2024

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented Sep 13, 2024 •
edited
Loading

  • Qiskit dep version set in lock step with aqp
  • output semantics can be configured on the backends needed for QIR generation. Program type exported as well.
  • Program type is separated from name of operation.
  • Updating to use walrus operator to simplify logic (supported by Python 3.8+).
  • Fixed doc comments
  • Fixed Q# code generation for debugging
  • RE now uses compile_qasm_enriching_errors so that entry points with input vars are rejected.

@idavis idavis self-assigned this Sep 13, 2024
@idavis idavis marked this pull request as ready for review September 17, 2024 16:11
swernli
swernli reviewed Sep 17, 2024
View reviewed changes
pip/src/interpreter.rs Outdated Show resolved Hide resolved
swernli
swernli reviewed Sep 17, 2024
View reviewed changes
pip/qsharp/_native.pyi Outdated Show resolved Hide resolved
idavis and others added 3 commits September 17, 2024 12:57
minestarks
minestarks reviewed Sep 18, 2024
View reviewed changes
pip/qsharp/_native.pyi Outdated Show resolved Hide resolved
@idavis idavis added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 099da18 Sep 18, 2024
18 checks passed
@idavis idavis deleted the iadavis/bugbash branch September 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@minestarks minestarks minestarks approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

Assignees

@idavis idavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idavis @swernli @minestarks