Make entry sample more minimal #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manvi-Agrawal
commented
Jun 29, 2024
Manvi-Agrawal
requested review from
cesarzc,
DmitryVasilevsky,
sezna,
swernli and
tcNickolas
as code owners
Manvi-Agrawal
commented
Jun 29, 2024
sezna
approved these changes
Jun 29, 2024
|
I think this is the right set of changes, but we should hold off on merging until we are closer to a release. Since the samples also act as a live set of references for users, we don't want to update samples with newer syntax or patterns that don't work in currently released version. This should get merged either right before or right after our next release, which will be the first to include the support for skipping |
|
@swernli I saw QDK v1.7.0 is released now and I tested this PR. Could you please merge this? Thanks. |
tcNickolas
approved these changes
Jul 26, 2024
DmitryVasilevsky
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/qsharp/pull/1579/files#r1632066063