Skip to content

More precise completions and namespace member completions #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 17, 2024
Merged

More precise completions and namespace member completions #1947

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9cf51c8
member completions
minestarks Oct 3, 2024
74a3930
rename to PathKind
minestarks Oct 4, 2024
42fcb76
rename function
minestarks Oct 4, 2024
38a9916
add a nested syntax test case
minestarks Oct 4, 2024
93c3360
bit more cleanup and more test cases
minestarks Oct 7, 2024
3c5b548
add a few missed keywords, WordKinds is now u128
minestarks Oct 11, 2024
7c89f2b
UPDATE_EXPECT=1
minestarks Oct 11, 2024
96d6dce
Handle when path ends with a keyword, and multi-character op tokens
minestarks Oct 11, 2024
6aa91b5
CR feedback and fix keyword spans
minestarks Oct 16, 2024
ec19e7a
Merge branch 'main' of https://github.com/microsoft/qsharp into mines…
minestarks Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions compiler/qsc/src/interpret/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,7 +1346,9 @@ mod given_interpreter {
use expect_test::expect;
use indoc::indoc;

use qsc_ast::ast::{Expr, ExprKind, NodeId, Package, Path, Stmt, StmtKind, TopLevelNode};
use qsc_ast::ast::{
Expr, ExprKind, NodeId, Package, Path, PathKind, Stmt, StmtKind, TopLevelNode,
};
use qsc_data_structures::span::Span;
use qsc_frontend::compile::SourceMap;
use qsc_passes::PackageType;
Expand Down Expand Up @@ -1865,7 +1867,7 @@ mod given_interpreter {
let path_expr = Expr {
id: NodeId::default(),
span: Span::default(),
kind: Box::new(ExprKind::Path(Box::new(path))),
kind: Box::new(ExprKind::Path(PathKind::Ok(Box::new(path)))),
};
let expr = Expr {
id: NodeId::default(),
Expand Down
2 changes: 1 addition & 1 deletion compiler/qsc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ pub mod circuit {
}

pub mod parse {
pub use qsc_parse::top_level_nodes;
pub use qsc_parse::{completion, top_level_nodes};
}

pub mod partial_eval {
Expand Down
24 changes: 0 additions & 24 deletions compiler/qsc/src/packages/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,30 +237,6 @@ fn dependency_error() {
),
),
},
WithSource {
sources: [
Source {
name: "librarymain",
contents: "broken_syntax",
offset: 0,
},
],
error: Frontend(
Error(
Parse(
Error(
ExpectedItem(
Eof,
Span {
lo: 0,
hi: 13,
},
),
),
),
),
),
},
]
"#]]
.assert_debug_eq(&buildable_program.dependency_errors);
Expand Down
Loading