-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prompty: fix parsing of tool_calls when array in arguments #3820
base: main
Are you sure you want to change the base?
Conversation
Hello @ianchi, thx for your PR. Do you have a GH issue that contains the specific error you run into? It will be nice if you can link the issue. |
Hi @luigiw, any news on this? |
Hi, any chance to advance with this? |
Hi @luigiw, please can you comment on this? |
SDK CLI Global Config Test Result tool_calls0 tests 0 ✅ 0s ⏱️ Results for commit 401ccad. |
Executor E2E Test Result tool_calls0 tests 0 ✅ 0s ⏱️ Results for commit 401ccad. |
Executor Unit Test Result tool_calls0 tests 0 ✅ 0s ⏱️ Results for commit 401ccad. |
Description
Current regex for parsing of tool_calls breaks if there is an array in the arguments (as it has a ']').
Consume up to end of block so it only matches the closing ']' and not any intermediate ones.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines