fix(chromium): bypass service workers on the storage state page - #42664
Merged
Merged
Conversation
Pavel Feldman (pavelfeldman)
approved these changes
Sep 10, 2026
Contributor
Test results for "tests 1"1 failed 6 flaky51673 passed, 1247 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 8347 passed, 1376 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
merged commit Sep 14, 2026
654654f
into
microsoft:main
43 of 45 checks passed
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storageState()visits each origin with an internal page that fulfills every request with an empty document, but in Chromium a service worker serves the navigation before request interception can, so the site's own scripts run during the capture and a redirect from them aborts it.Network.setBypassServiceWorker, so its navigations reach the interceptor.Fixes #42656