Skip to content

test(connect): unblock hung launchServer teardown with SIGKILL fallback #42148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
microsoft-playwright-automation wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

test(connect): unblock hung launchServer teardown with SIGKILL fallback #42148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tests/config/remoteServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,17 @@ export class RemoteServer implements PlaywrightServer {
await this._browser.close();
this._browser = undefined;
}
await this._process.kill('SIGINT');
await this.childExitCode();
// The launchServer child forwards SIGINT to gracefully close the browser and
// then exit. A headed browser can intermittently fail to terminate on SIGINT
// (observed on macOS chromium), which leaves the child alive and hangs
// teardown until the test timeout. Give graceful shutdown a chance, then
// escalate to SIGKILL so teardown stays bounded.
void this._process.kill('SIGINT');
const killTimer = setTimeout(() => void this._process.kill('SIGKILL'), 10000);
try {
await this.childExitCode();
} finally {
clearTimeout(killTimer);
}
}
}
Loading