fix(mcp): close browser process on backend disposal#40040
Closed
RedhatEnt wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix(mcp): close browser process on backend disposal#40040RedhatEnt wants to merge 1 commit intomicrosoft:mainfrom
RedhatEnt wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The API (`createConnection`) and extension server backend factories had no-op `disposed` callbacks, leaving browser processes running as zombies after `browser_close` or client disconnect. Mirror the existing CLI factory behavior: close the browser context and browser on disposal. Fixes: microsoft/playwright-mcp#1458
Author
|
@microsoft-github-policy-service agree company="Noetic Emergence Consulting LLC" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createConnection) and extension backend factories had no-opdisposedcallbacks, leaving browser processes running afterbrowser_closeor client disconnectbrowserContext.close()+browser.close()to both factories, matching the existing CLI factory behaviorFixes microsoft/playwright-mcp#1458