fix(clock): handle NS_ERROR_NOT_INITIALIZED in Firefox embedder timers#40012
Open
7rulnik wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(clock): handle
NS_ERROR_NOT_INITIALIZED in Firefox embedder timers#400127rulnik wants to merge 1 commit intomicrosoft:mainfrom
7rulnik wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Firefox throws NS_ERROR_NOT_INITIALIZED when calling native setTimeout/setInterval on a window whose context is no longer available. This wraps the embedder timer calls in try/catch so the clock recovers gracefully instead of crashing. Fixes microsoft#40011
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NS_ERROR_NOT_INITIALIZEDwhen calling nativesetTimeout/setIntervalon a window whose JS context is no longer availablecreateClock()uses saved native timer references for the real-time sync loop, which can throw when the window contextbecomes unavailable
setTimeout/setIntervalcalls in try/catch so the clock skips one sync tick and recoversFixes #40011