Skip to content

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jan 7, 2026

No description provided.

@Skn0tt Skn0tt requested a review from dgozman January 7, 2026 09:52

for (const [botName, tests] of Object.entries(bots)) {
const botShards = shardsInfo.filter(shard => shard.tag.join(';') === botName);
const totalShard = Math.max(...botShards.map(s => s.shardIndex ?? -1));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this code lived on the client side, we could make totalShard a UI control and the user could see optimal weights for different numbers of shards

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.


```bash
npx playwright test --shard=1/4 --shard-weights=26:24:25:25
npx playwright test --shard=x/4 --shard-weights=30:20:25:25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be less confusing, if example weights do not sum up to 100. Otherwise, one may get a false impression that's required.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Test results for "MCP"

3 failed
❌ [chrome] › mcp/launch.spec.ts:80 › persistent context @mcp-macos-15
❌ [chrome] › mcp/planner.spec.ts:131 › planner_setup_page with dependencies @mcp-macos-15
❌ [chrome] › mcp/test-debug.spec.ts:167 › test_debug (pause/snapshot/resume) @mcp-macos-15

2819 passed, 116 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Test results for "tests 1"

6 failed
❌ [playwright-test] › config.spec.ts:349 › should print nice error when project is unknown and launching UI mode @macos-latest-node20
❌ [playwright-test] › expect.spec.ts:508 › should support toHaveURL with baseURL from webServer @macos-latest-node20
❌ [playwright-test] › expect.spec.ts:642 › should only highlight unmatched regex in diff message for toHaveText with array @macos-latest-node20
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @macos-latest-node20
❌ [playwright-test] › reporter-html.spec.ts:1037 › created › should have link for opening HTML attachments in new tab @macos-latest-node20

1 flaky ⚠️ [playwright-test] › ui-mode-trace.spec.ts:796 › should update state on subsequent run `@windows-latest-node20`

34409 passed, 696 skipped


Merge workflow run.

@Skn0tt Skn0tt merged commit 39190df into microsoft:main Jan 8, 2026
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants