fix(windows): clear diagnostics errors #584
Open
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats happening?
The issue is that we write errors to a Map with "Node.js like paths" so that the drive-letter is uppercase but we delete them out of the map by using the VSCode workspace change event, which are VSCode like paths, which have always lowercase drive letters.
This PR wraps when calling
set
insidethis._vscode.Uri.file(path).fsPath
which normalises and is what we already do for other places when we interact with locations from the reporter API.playwright-vscode/src/testModel.ts
Lines 395 to 396 in ffcd83a
Resolves microsoft/playwright#34146
Resolves microsoft/playwright#33671