fix(connection): reject pending callbacks on transport death - #3170
Open
Simon Knott (Skn0tt) wants to merge 1 commit into
Open
fix(connection): reject pending callbacks on transport death#3170Simon Knott (Skn0tt) wants to merge 1 commit into
Simon Knott (Skn0tt) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3351313b-bb35-475c-ae04-f79e1d2e4086
| # relies on it to attribute rejections to the right test. | ||
| if browser: | ||
| connection._loop.call_soon(browser._on_close) | ||
| connection.cleanup(reason) |
There was a problem hiding this comment.
this seems like it'd reintroduce the problem solved by #3135
| }, | ||
| return_when=asyncio.FIRST_COMPLETED, | ||
| ) | ||
| result = await callback.future |
There was a problem hiding this comment.
this seems like it'd reintroduce the problem solved by #3144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every send used to race the protocol callback against
transport.on_error_future, because a dead pipe only completed that future and never tore down in-flight calls.This matches the Node client more closely:
Connection.run()callscleanup()when the transport ends, which rejects every pending callback. Sends just await their own future.For remote connect,
browser._on_closeis stillcall_soon'd beforecleanup(), so waiters still see reject-before-disconnect ordering.