feat(mcp): add $schema reference in README and sync schema in roll.js#1508
Closed
lennondotw wants to merge 1 commit intomicrosoft:mainfrom
Closed
feat(mcp): add $schema reference in README and sync schema in roll.js#1508lennondotw wants to merge 1 commit intomicrosoft:mainfrom
lennondotw wants to merge 1 commit intomicrosoft:mainfrom
Conversation
- Add $schema example to the Configuration file section in README - Extend roll.js copyConfig() to also copy mcp-config.schema.json from playwright-core, so the schema ships with the npm package Depends on: microsoft/playwright#40025
Contributor
Author
|
Closing — the upstream PR (microsoft/playwright#40025) was closed as the team decided against the JSON Schema approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$schemaexample to the Configuration file section in READMEroll.jscopyConfig()to also copymcp-config.schema.jsonfromplaywright-core, so the schema ships with the@playwright/mcpnpm packageDepends on microsoft/playwright#40025 (the schema generator and output file).