Repository navigation
Fix synchronization race in upgrade tests - #421
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Thom Chiovoloni (thomcc-work)
October 9, 2026 18:12
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The bounded polling correctly addresses the race without weakening test coverage.
0 open findings
What changed in this PR
Adds provider-state polling to eliminate a race causing flaky upgrade tests.
Changes:
- Polls both orchestration states until completion or timeout.
- Documents the distinction between workflow and provider completion.
| File | Description |
|---|---|
scripts/test-upgrade.sh |
Replaces immediate assertions with bounded polling. |
docs/upgrade-testing.md |
Documents completion synchronization behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes CI to be flakey.