Binary symbol-server lookup 404s for /Brepro builds with leading-zero#2417
Open
ivberg wants to merge 1 commit intomicrosoft:mainfrom
Open
Binary symbol-server lookup 404s for /Brepro builds with leading-zero#2417ivberg wants to merge 1 commit intomicrosoft:mainfrom
ivberg wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ng zero
SymbolReader.FindExecutableFilePath built the symbol-server key with
buildTimestamp.ToString("x"), which drops the leading hex zero when the
value is < 0x10000000. The symbol-server convention (matched by symsrv
and symchk) requires TimeDateStamp zero-padded to 8 hex digits and
SizeOfImage variable-width — so the produced URL is one digit short and
404s even when the binary is indexed.
This affects PE binaries built with /Brepro (deterministic builds),
whose hash-based TimeDateStamp can legitimately have leading hex zeros.
Concrete repro: SystemSettings.dll on recent Windows builds with
TS=0x0D9F641E, SizeOfImage=0x599000 — server has key 0d9f641e599000,
TraceEvent emitted d9f641e599000.
Fix: use "x8" for TimeDateStamp. SizeOfImage stays "x" since the
convention is variable-width there.
PDB lookup (line 245) is unaffected: the GUID component uses "N" which
always emits 32 chars regardless of value, and Age is variable-width on
both client and server by convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary symbol-server lookup 404s for /Brepro builds with leading-zero
SymbolReader.FindExecutableFilePath built the symbol-server key with
buildTimestamp.ToString("x"), which drops the leading hex zero when the
value is < 0x10000000. The symbol-server convention (matched by symsrv
and symchk) requires TimeDateStamp zero-padded to 8 hex digits and
SizeOfImage variable-width — so the produced URL is one digit short and
404s even when the binary is indexed.
This affects PE binaries built with /Brepro (deterministic builds),
whose hash-based TimeDateStamp can legitimately have leading hex zeros.
Concrete repro: SystemSettings.dll on recent Windows builds with
TS=0x0D9F641E, SizeOfImage=0x599000 — server has key 0d9f641e599000,
TraceEvent emitted d9f641e599000.
Fix: use "x8" for TimeDateStamp. SizeOfImage stays "x" since the
convention is variable-width there.
PDB lookup (line 245) is unaffected: the GUID component uses "N" which
always emits 32 chars regardless of value, and Age is variable-width on
both client and server by convention.
Fixes #2416