virtio_net: fix write_data delivering corrupt packets on guest memory failure#2887
Draft
benhillis wants to merge 1 commit intomicrosoft:mainfrom
Draft
virtio_net: fix write_data delivering corrupt packets on guest memory failure#2887benhillis wants to merge 1 commit intomicrosoft:mainfrom
benhillis wants to merge 1 commit intomicrosoft:mainfrom
Conversation
… failure write_data previously set the packet length unconditionally, even when the guest memory write failed. This caused corrupt or partial data to be delivered to the guest. Additionally, write_header would panic on its length assertion since the stored length didn't match reality. Fix write_data to only update the packet length on success. Add an early return in write_header when len is 0, allowing the packet to complete with zero length so the guest discards it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_data previously set the packet length unconditionally, even when the guest memory write failed. This caused corrupt or partial data to be delivered to the guest. Additionally, write_header would panic on its length assertion since the stored length didn't match reality.
Fix write_data to only update the packet length on success. Add an early return in write_header when len is 0, allowing the packet to complete with zero length so the guest discards it.