CVM: Audit tracing and add ALLOWED/CONFIDENTIAL where appropriate #1408
+475
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
added
the
backport_2505
sluck-msft
reviewed
May 24, 2025
mebersol
reviewed
May 25, 2025
does this get logged in a debug-disabled CVM? If not, do we want a non-specific error message logged for this case? Refers to: openhcl/virt_mshv_vtl/src/processor/snp/mod.rs:1575 in 8476372. [](commit_id = 8476372, deletion_comment = False) |
|
Yes, panic messages should still get logged in a debug-disabled CVM. One of the things I'm working on this week is validating that. |
jstarks
reviewed
May 27, 2025
smalis-msft
force-pushed
the
tracing_audit
branch
from
a41c9e8 to
c0b26d5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jstarks
reviewed
May 30, 2025
jstarks
reviewed
May 30, 2025
jstarks
reviewed
May 30, 2025
smalis-msft
force-pushed
the
tracing_audit
branch
from
5ce24a4 to
53b5f1a
Compare
jstarks
approved these changes
May 30, 2025
smalis-msft
added a commit
to smalis-msft/openvmm
that referenced
this pull request
Jun 3, 2025
…crosoft#1408) Also includes some drive-by cleanups where I happened to see them. Areas I did not audit because they are not relevant to CVMs: - trace and debug level statements - Non-CVM workers (debug & VNC) - Test only code (petri, vmm_tests, tmk*) - ARM-specific code - Non-CVM virt backends (including virt_mshv_vtl/mshv) - Host-only code (openvmm, GED, igvmfilegen, etc) - Gen 1 devices (vga, chipset, etc) - VirtIO Areas that still need auditing by owners and area experts: - Mesh (@jstarks) - Networking (vm/devices/net/* & underhill_core/netvsp) (networking team) - Storage (vm/devices/storage/* & underhill_core/nvme_manager) (storage team) - VMBus (vm/devices/vmbus/*) (@SvenGroot) - VMGS (vm/vmgs/*) (@tjones60) Part of microsoft#852
benhillis
pushed a commit
that referenced
this pull request
Jun 4, 2025
) (#1460) Also includes some drive-by cleanups where I happened to see them. Areas I did not audit because they are not relevant to CVMs: - trace and debug level statements - Non-CVM workers (debug & VNC) - Test only code (petri, vmm_tests, tmk*) - ARM-specific code - Non-CVM virt backends (including virt_mshv_vtl/mshv) - Host-only code (openvmm, GED, igvmfilegen, etc) - Gen 1 devices (vga, chipset, etc) - VirtIO Areas that still need auditing by owners and area experts: - Mesh (@jstarks) - Networking (vm/devices/net/* & underhill_core/netvsp) (networking team) - Storage (vm/devices/storage/* & underhill_core/nvme_manager) (storage team) - VMBus (vm/devices/vmbus/*) (@SvenGroot) - VMGS (vm/vmgs/*) (@tjones60) Part of #852 Cherry-pick of #1408
|
Backported in #1460 |
benhillis
added
backported_2505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some drive-by cleanups where I happened to see them.
Areas I did not audit because they are not relevant to CVMs:
Areas that still need auditing by owners and area experts:
Part of #852