-
Notifications
You must be signed in to change notification settings - Fork 123
CVM: Audit tracing and add ALLOWED/CONFIDENTIAL where appropriate #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -606,7 +614,7 @@ async fn read_device_platform_settings( | |||
|
|||
// TODO: figure out if we really need to trace this. These are too long for | |||
// the Underhill trace buffer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably leave as long as we're still logging it. But this is why I downgraded it.
does this get logged in a debug-disabled CVM? If not, do we want a non-specific error message logged for this case? Refers to: openhcl/virt_mshv_vtl/src/processor/snp/mod.rs:1575 in 8476372. [](commit_id = 8476372, deletion_comment = False) |
Yes, panic messages should still get logged in a debug-disabled CVM. One of the things I'm working on this week is validating that. |
Also includes some drive-by cleanups where I happened to see them.
Areas I did not audit because they are not relevant to CVMs:
Areas that still need auditing by owners and area experts:
Part of #852