petri: Disable secure boot by default for HyperV tests and introduce specific secureboot tests #1386
Conversation
maheeraeron
changed the title
|
Think the title and description need updating |
| @@ -67,6 +67,29 @@ async fn boot(config: Box<dyn PetriVmConfig>) -> anyhow::Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Basic boot test with secure boot enabled. | |||
| #[vmm_test( | |||
There was a problem hiding this comment.
Do we have other tests with secure boot that can be removed/folded into this?
There was a problem hiding this comment.
good point, ill have to look around for these
There was a problem hiding this comment.
as far as I know, looks like we don't have any other tests with secure boot explicitly?
I did notice guest_test_uefi multiarch test has with_windows_secure_boot_template().
My new with_secure_boot() could be used instead? But I'm not sure if, based on the OsFlavor for guest_test_uefi_x64 or guest_test_uefi_aarch64 what the correct secure boot template would be in this case-- must it be the windows template?
There was a problem hiding this comment.
Should we add a test that verifies Linux fails to boot with the Windows secure boot template?
There was a problem hiding this comment.
Yes, we should-- I'll add these negative tests next
Oh, I kept the title for now since this might still be a work in progress. I made this PR away from draft so that I can test the CI runs |
|
Well it's still a WIP, but the change we're actually making is the opposite of the current title |
maheeraeron
changed the title
| async fn secure_boot(config: Box<dyn PetriVmConfig>) -> anyhow::Result<()> { | ||
| let mut vm = config.with_secure_boot().run_without_agent().await?; | ||
| vm.wait_for_successful_boot_event().await?; | ||
| assert_eq!(vm.wait_for_teardown().await?, HaltReason::PowerOff); |
There was a problem hiding this comment.
What is telling these vms to shut down? You probably need to add a call to enlightened_shutdown
This PR focuses on:
with_secure_bootfunction that injects a secure boot template per OS flavor