[node] Fix logging mutex crash at exit on macOS #26459
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash at
OrtReleaseEnvon macOS (and other libc platforms) caused by mutex destruction order issues in the default logger.Solution: Refactor Node.js binding to use Meyer's Singleton pattern for ORT environment lifecycle, intentionally leaking
Ort::Envat program exit to avoid destructor ordering problems.Implementation:
OrtSingletonData: Meyer's Singleton managing globalOrt::Envand defaultOrt::RunOptionsvia function-local staticOrtInstanceData: Per-environment N-API instance data for thread-local constructor referencesOrt::Envnever destroyed, eliminatingOrtReleaseEnvcall that triggered the crashFixes #24579
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.