Skip to content

[MIGraphX EP] Bugfix for toVector Function causing rollover with int64 inputs #26403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MIGraphX EP] Bugfix for toVector Function causing rollover with int64 inputs #26403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,11 +364,11 @@ static bool getMIGraphXType(ONNXTensorElementDataType type,
return true;
}

std::vector<int> toVector(const ONNX_NAMESPACE::int64s& nums) {
std::vector<int> result;
int num = nums.size();
for (int i = 0; i < num; ++i) {
result.push_back(static_cast<int>(nums[i]));
std::vector<int64_t> toVector(const ONNX_NAMESPACE::int64s& nums) {
std::vector<int64_t> result;
size_t num = nums.size();
for (size_t i = 0; i < num; ++i) {
result.push_back(nums[i]);
}

return result;
Expand Down Expand Up @@ -541,6 +541,7 @@ static bool IsUnsupportedOpMode(const onnxruntime::GraphViewer& graph_viewer, co
if (attributes.count("starts") > 0 && attributes.count("ends") > 0) {
auto starts = toVector((*attributes.find("starts")).second.ints());
auto ends = toVector((*attributes.find("ends")).second.ints());

for (std::size_t i = 0; i < starts.size(); ++i) {
if (starts.at(i) > ends.at(i)) {
return true;
Expand Down