-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TensorRT EP] revert oss parser to 10.7-GA #23710
base: main
Are you sure you want to change the base?
Conversation
The TRT CI has building issue. |
onnx-tensorrt introduced a dependency plugin.h, which is available by tarball/zip installation (under |
this is a bit confusing. if we publish packages built against TRT 10.8 but stay with10.7 parser? |
Why previously when our CI was running with TRT 10.6 built-in parser didn't complain about this plugin.h depedency? |
This dependency is only needed by oss parser. CIs that use Bulit-in parser have no issue even though there's no plugin.h |
You mention "Updating the logic to make sure builtin parser users are not blocked", it should be oss parser, right? |
endif() | ||
|
||
# Check TRT version >= requirement | ||
function(check_trt_version req_major req_minor req_patch out_var) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is much complex than the original check.
In additions to check 10.0.1, do we need to check other TRT version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far it's not needed. I will clean this
I didn't mention that clearly. |
Description
Motivation and Context
OSS 10.8-GA can't work with ONNX 1.17, which will cause ORT build failure when enabling
--use_tensorrt_oss_parser
Action needed to adapt latest 10.7-GA or 10.8-GA oss parser branch to fix scatterND attribute issue