Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacity aware partitioning #22766

Merged
merged 17 commits into from
Feb 20, 2025
Merged

Conversation

yuslepukhin
Copy link
Member

@yuslepukhin yuslepukhin commented Nov 7, 2024

Description

Allow users to specify per EP specific resource constraints.
Currently, models that do not fit into device memory error out.

This PR lays groundwork for EP specific resource constrained graph
partitioning, subject to incremental feature additions.

Partitioning in this context means to assign graph nodes to a specific device (Execution Provider)
up to a certain limit that is every automatically inferred or provided by configuration.

In this implementation, we stop assigning nodes to CUDA once we reach the specified memory limit.

This allows users to run models on devices with limited memory or other limited resources and
offload parts of the graph on CPU or other EPs as configured.

The PR also introduces an ability to profile and save resource consumption on a per node basis.
The results of one or more runs are saved into a CSV file which can then be loaded to assist
partitioning.

Model architecture-based partitioning (like put N transformer blocks on GPU and embedding on CPU) is not implemented in this PR but will be coming in the future.

Motivation and Context

We want to allow models to run in constrained environments.

Pending

Annotation assisted partitioning

@yuslepukhin yuslepukhin changed the title [DRAFT] Graph aware partitioning [DRAFT] Resource aware partitioning Nov 7, 2024
@yuslepukhin yuslepukhin changed the title [DRAFT] Resource aware partitioning [DRAFT] Capacity aware partitioning Nov 7, 2024
@tianleiwu
Copy link
Contributor

tianleiwu commented Nov 8, 2024

How about the intermediate memory usage (workspace) for each node? That is usually unknown during partitioning, and even unknown during inference since op has no interface to tell its workspace size right now. For example, MultiHeadAttention op might call different cuda kernels (flash attention, cutlass fmha, tensorrt fmha kernel or unfused kernel), each has different memory consumption.

@yuslepukhin
Copy link
Member Author

yuslepukhin commented Nov 8, 2024

How about the intermediate memory usage (workspace) for each node? That is usually unknown during partitioning, and even unknown during inference since op has no interface to tell its workspace size right now.

This is true. The function is currently accounts for initializers and inputs. It cannot account for temporary allocations because those are done at inference time, and partitioning takes place well before kernels are instantiated.

The approach of computing memory patterns cannot be taken here since that relies on the presence of a runnable model which we do not have today in a constrained environment.

This PR is still at the experimental stage. I envision that most of the burden would be placed on the individual EPs GetCapability since EPs are in the best position to know the constraints which can be different from memory only or there might be additional considerations that may be accounted in the Resource Count.

The simplest way is to add an additional if/else to enumerate the kernels and attempt to infer the amount of temporary space. However, that creates an additional maintenance burden since we already have plenty of such places in optimizers and what not where we need to make sure that changes to individual kernels are reflected.

However, it would still work in its current form. One can try one setting and then lower it if the consumption is too much.

Another idea would be to run the model beforehand and record the consumption. Then use that trace to set the limit n the constrained environment.

@tianleiwu
Copy link
Contributor

The function is currently accounts for initializers and inputs. It cannot account for temporary allocations

If so, I think the feature is not very helpful for vision or LLMs models due to the limitations.

Another idea would be to run the model beforehand and record the consumption. Then use that trace to set the limit n the constrained environment.

That's a good idea, and it will be great that we can support the use case.

BTW, a general way to help capacity constraint is that we can have a way to manually configure location of initializers and inputs. This can be extended to support offloading initializers to CPU, and only load them on the GPU when needed.

@yuslepukhin yuslepukhin force-pushed the yuslepukhin/graph_constrained_paritioning branch 4 times, most recently from 6244735 to b2bb641 Compare January 16, 2025 23:00
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.


void NodeStatsRecorder::ReportNodeStats(const std::string& node_name, const NodeAllocationStats& stats) {
std::lock_guard lock(impl_->mut_);
auto result = impl_->node_stats_.emplace(node_name, stats);

Check warning

Code scanning / PREfast

The pointer is dangling because it points at a temporary instance which was destroyed.

The pointer is dangling because it points at a temporary instance which was destroyed.
@yuslepukhin yuslepukhin force-pushed the yuslepukhin/graph_constrained_paritioning branch from 7596ac5 to cb2277d Compare January 24, 2025 18:51
    Implement GetSizeFromTensorTypeProo
    Wire in accounting
    Make CUDA EP resource aware and account on assignment
    Fix missing accountant for Ort format
    Remove redundant functions
    Remove unnecessary interface
    Fix DML issue, minor fixes
    Fix alert
    DEMO changes
    Implement node memory stats collection
    Place container in the session.
    Support nested graphs
    Add synchronization
    Update stats for the max consumption.
    Introduce input sizes computation.
@yuslepukhin yuslepukhin force-pushed the yuslepukhin/graph_constrained_paritioning branch from 91dfeca to 3d805b0 Compare January 27, 2025 22:38
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

@Craigacp
Copy link
Contributor

Craigacp commented Feb 12, 2025

What's the timeline on allowing more fine grained op placement after this PR has landed? We're hitting placement issues with tokenization ops that are required to be on CPU causing trouble when the rest of the graph is placed on GPU, and we'd like to be able to pin more of the tokenization subgraph onto CPU. More information is given here - #23154.

tianleiwu
tianleiwu previously approved these changes Feb 19, 2025
@yuslepukhin yuslepukhin merged commit b230c7b into main Feb 20, 2025
95 of 97 checks passed
@yuslepukhin yuslepukhin deleted the yuslepukhin/graph_constrained_paritioning branch February 20, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants