[202405][Rebase&&FF] Everything MS Changes #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Flickdm
commented
Jul 30, 2024
SecurityPkg/Library/DxeTcg2PhysicalPresenceLib/DxeTcg2PhysicalPresenceLib.c
Outdated
Show resolved
Hide resolved
Flickdm
commented
Jul 30, 2024
SecurityPkg/Library/DxeTcg2PhysicalPresenceLib/DxeTcg2PhysicalPresenceLib.c
Outdated
Show resolved
Hide resolved
Flickdm
commented
Jul 30, 2024
SecurityPkg/Library/DxeTcg2PhysicalPresenceLib/DxeTcg2PhysicalPresenceLib.c
Outdated
Show resolved
Hide resolved
Flickdm
commented
Jul 30, 2024
SecurityPkg/Library/DxeTcg2PhysicalPresenceLib/DxeTcg2PhysicalPresenceLib.c
Outdated
Show resolved
Hide resolved
os-d
reviewed
Jul 30, 2024
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/ms-changes
branch
2 times, most recently
from
acc8bc1
to
9ca5e19
Compare
makubacki
reviewed
Jul 30, 2024
makubacki
reviewed
Jul 30, 2024
makubacki
reviewed
Jul 30, 2024
makubacki
reviewed
Jul 30, 2024
makubacki
reviewed
Jul 30, 2024
SecurityPkg/Library/DxeTcg2PhysicalPresenceLib/DxeTcg2PhysicalPresenceLib.c
Outdated
Show resolved
Hide resolved
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/ms-changes
branch
4 times, most recently
from
f6724b7
to
9c633e5
Compare
Flickdm
commented
Jul 31, 2024
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/ms-changes
branch
8 times, most recently
from
3cabe69
to
4e623f3
Compare
os-d
approved these changes
Aug 1, 2024
SecurityPkg/Library/DxeTcg2PhysicalPresenceLib/DxeTcg2PhysicalPresenceLib.c
Outdated
Show resolved
Hide resolved
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/ms-changes
branch
4 times, most recently
from
46f0be1
to
f4aab82
Compare
makubacki
reviewed
Aug 2, 2024
SecurityPkg/Library/DxeTcg2PhysicalPresenceLib/DxeTcg2PhysicalPresenceLib.c
Show resolved
Hide resolved
makubacki
approved these changes
Aug 2, 2024
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/ms-changes
branch
2 times, most recently
from
c4e73b0
to
1b08b94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #311 +/- ##
================================================
Coverage ? 0.54%
================================================
Files ? 147
Lines ? 34764
Branches ? 167
================================================
Hits ? 190
Misses ? 34466
Partials ? 108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Aug 9, 2024
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/ms-changes
branch
from
50acf3d
to
1d47375
Compare
Adds the following:
+ SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
+ SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
+ SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf
+ SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf
Add a debug message to show the TPM2 PCR bank info in Tcg2Dxe. Prints out both the TpmHashalgorithmBitmap and the Pcr banks.
This replaces a assert for a proper runtime check for the status of Tpm2GetCapabilitySupportedAndActivePcrs()
This commit adds support to Tpm2Help.c to query the TPM for supported hash algorithms.
This change describes the interface that should be published by instances of the Tcg2PreUefiEventLogLib. This library can be used to publish TPM EventLog entries for measurements that may have been made prior to driver initialization
Ensures that if SecureBootEnable is found and mPlatformMode is USER_MODE that SecureBootEnable == SECURE_BOOT_MODE_ENABLE.
The code to display the confirmation dialog is moved to a helper function to make the code more readable and maintainable. This is for DxeTcg2PhysicalPresenceLib.
Adds a flag to disable TCG2 flags from bypassing confirmation in production mode.
The TPM2_Startup() function is called in the Tcg2Pei driver to start the TPM. The function is expected to return an error if the TPM is not in the correct state.
Since the commit: "SecurityPkg: Do not allow Flags to bypass confirmation in Production" modified DxeTcg2PhysicalPresenceLib.inf the override in DxeTcg2PhysicalPresenceMinimumLib.inf needs to be updated to reflect the changes.
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/ms-changes
branch
from
1d47375
to
b542b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0461663
Description
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Local CI
Integration Instructions
N/A