Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rebase& FF] 202405: SecurityPkg/Tcg2Smm: Added communicate buffer check #289

Conversation

VivianNK
Copy link
Contributor

@VivianNK VivianNK commented Jun 28, 2024

Description

Added communicate buffer check for the Tcg2Smm driver in lieu of the legacy MmOutsideValid check.


Cherry-picked commit:

4d4080f


  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Changes from release/202311

Integration Instructions

N/A

@VivianNK VivianNK force-pushed the personal/vnowkakeane/2405_smm_buff_protec branch from 09305cf to 84b36b8 Compare June 28, 2024 00:37
@VivianNK VivianNK changed the title SecurityPkg: Tcg2Smm: Added communicate buffer check SecurityPkg/Tcg2Smm: Added communicate buffer check Jun 28, 2024
@VivianNK VivianNK changed the title SecurityPkg/Tcg2Smm: Added communicate buffer check [Rebase& FF] 202405: SecurityPkg/Tcg2Smm: Added communicate buffer check Jun 28, 2024
@os-d os-d force-pushed the personal/vnowkakeane/2405_smm_buff_protec branch from 84b36b8 to c7d1f6c Compare July 3, 2024 19:52
@VivianNK VivianNK force-pushed the personal/vnowkakeane/2405_smm_buff_protec branch from c7d1f6c to 4e33873 Compare July 17, 2024 21:26
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@03949c6). Learn more about missing BASE report.

Files Patch % Lines
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/202405    #289   +/-   ##
================================================
  Coverage                  ?   1.04%           
================================================
  Files                     ?     136           
  Lines                     ?   33602           
  Branches                  ?     168           
================================================
  Hits                      ?     352           
  Misses                    ?   33250           
  Partials                  ?       0           
Flag Coverage Δ
SecurityPkg 1.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged PR 5400
Added communicate buffer check for the Tcg2Smm driver in lieu of the legacy MmOutsideValid check.
@VivianNK VivianNK force-pushed the personal/vnowkakeane/2405_smm_buff_protec branch from 4e33873 to 8944ad6 Compare July 17, 2024 22:25
@VivianNK VivianNK merged commit c40372f into microsoft:release/202405 Jul 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants