Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IpmiFeaturePkg/IpmiSmbios/GoogleTest/IpmiSmbiosGoogleTest: Fix unit t… #239

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Jun 21, 2024

Description

Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Once this bug was fixed, the unit tests starting to be compiled which blocked pipelines.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Local CI.

Integration Instructions

N/A

@apop5 apop5 requested review from cfernald and os-d June 21, 2024 20:51
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jun 21, 2024
…est compilation errors.

Unit tests started failing due to compilation errors. This stemmed from
a bug fixed in microsoft/mu_basecore#891. Once this bug was fixed, the
unit tests starting to be compiled which blocked pipelines.
@apop5 apop5 force-pushed the personal/apop5/fixunittests branch from 8fbf760 to c4277ec Compare June 21, 2024 20:57
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.85%. Comparing base (429bc82) to head (c4277ec).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   25.82%   27.85%   +2.02%     
==========================================
  Files          44       44              
  Lines        3245     2987     -258     
  Branches      271      275       +4     
==========================================
- Hits          838      832       -6     
+ Misses       2401     2149     -252     
  Partials        6        6              
Flag Coverage Δ
IpmiFeaturePkg 27.85% <ø> (+2.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5 apop5 merged commit 1f0dd44 into microsoft:main Jun 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants